From 8be458f768a5008bedd618c592e422ba85e54cf0 Mon Sep 17 00:00:00 2001
From: Crystal Lai <crystal.lai@greenbone.net>
Date: Wed, 17 Jul 2019 10:22:07 +0200
Subject: [PATCH 1/5] added grow option to multiselect

---
 gsa/src/web/components/form/multiselect.js    | 3 +++
 gsa/src/web/components/form/selectelements.js | 1 +
 2 files changed, 4 insertions(+)

diff --git a/gsa/src/web/components/form/multiselect.js b/gsa/src/web/components/form/multiselect.js
index e922241d50..2a09a9fc8c 100644
--- a/gsa/src/web/components/form/multiselect.js
+++ b/gsa/src/web/components/form/multiselect.js
@@ -176,6 +176,7 @@ class MultiSelect extends React.Component {
       items,
       menuPosition = 'adjust',
       width = DEFAULT_WIDTH,
+      grow = '0',
     } = this.props;
 
     const {search, selectedItems} = this.state;
@@ -208,6 +209,7 @@ class MultiSelect extends React.Component {
               {...getRootProps({}, {suppressRefError: true})}
               className={className}
               width={width}
+              grow={grow}
             >
               <Box
                 isOpen={isOpen}
@@ -275,6 +277,7 @@ class MultiSelect extends React.Component {
 
 MultiSelect.propTypes = {
   disabled: PropTypes.bool,
+  grow: PropTypes.number,
   items: PropTypes.arrayOf(PropTypes.object),
   menuPosition: PropTypes.oneOf(['left', 'right', 'adjust']),
   name: PropTypes.string,
diff --git a/gsa/src/web/components/form/selectelements.js b/gsa/src/web/components/form/selectelements.js
index 6787de56b7..afca9bc5e1 100644
--- a/gsa/src/web/components/form/selectelements.js
+++ b/gsa/src/web/components/form/selectelements.js
@@ -222,6 +222,7 @@ Menu.propTypes = {
 export const SelectContainer = styled.div`
   display: flex;
   flex-direction: column;
+  flex-grow: ${props => props.grow}
   position: relative;
   width: ${props => props.width};
 `;

From e423edc713d43d3cf5ba260397cc8314a559385e Mon Sep 17 00:00:00 2001
From: Crystal Lai <crystal.lai@greenbone.net>
Date: Wed, 17 Jul 2019 10:41:25 +0200
Subject: [PATCH 2/5] removed grow prop from assign to user, as it does nothing

---
 gsa/src/web/pages/tickets/createdialog.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gsa/src/web/pages/tickets/createdialog.js b/gsa/src/web/pages/tickets/createdialog.js
index 5bae5c8917..da37309aa0 100644
--- a/gsa/src/web/pages/tickets/createdialog.js
+++ b/gsa/src/web/pages/tickets/createdialog.js
@@ -53,7 +53,6 @@ const CreateTicketDialog = ({
         <FormGroup title={_('Assign To User')}>
           <Select
             name="userId"
-            grow="1"
             value={values.userId}
             items={renderSelectItems(users)}
             onChange={onUserIdChange}

From 200420de5c175ab6ad1322b213112b510ceae0da Mon Sep 17 00:00:00 2001
From: Crystal Lai <crystal.lai@greenbone.net>
Date: Wed, 17 Jul 2019 10:45:34 +0200
Subject: [PATCH 3/5] updated snapshots

---
 .../form/__tests__/__snapshots__/multiselect.js.snap   |  4 ++++
 .../form/__tests__/__snapshots__/select.js.snap        |  5 ++++-
 .../form/__tests__/__snapshots__/selectelement.js.snap |  5 ++++-
 .../__tests__/__snapshots__/timezoneselect.js.snap     |  5 ++++-
 .../__tests__/__snapshots__/relationselector.js.snap   |  5 ++++-
 .../__snapshots__/severityvaluesgroup.js.snap          |  5 ++++-
 .../__tests__/__snapshots__/sortbygroup.js.snap        |  5 ++++-
 .../__tests__/__snapshots__/tagsdialog.js.snap         | 10 ++++++++--
 .../__tests__/__snapshots__/createdialog.js.snap       |  5 ++++-
 .../tickets/__tests__/__snapshots__/editdialog.js.snap |  5 ++++-
 10 files changed, 44 insertions(+), 10 deletions(-)

diff --git a/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap b/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
index a7e2ad8db1..597f9c93b3 100644
--- a/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
+++ b/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
@@ -113,6 +113,10 @@ exports[`MultiSelect component tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
+  -webkit-box-flex: 0;
+  -webkit-flex-grow: 0;
+  -ms-flex-positive: 0;
+  flex-grow: 0;
   position: relative;
   width: 250px;
 }
diff --git a/gsa/src/web/components/form/__tests__/__snapshots__/select.js.snap b/gsa/src/web/components/form/__tests__/__snapshots__/select.js.snap
index 086392cc23..b846341e0e 100644
--- a/gsa/src/web/components/form/__tests__/__snapshots__/select.js.snap
+++ b/gsa/src/web/components/form/__tests__/__snapshots__/select.js.snap
@@ -87,7 +87,10 @@ exports[`Select component tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 
diff --git a/gsa/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap b/gsa/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
index 4b76345766..9e536c7552 100644
--- a/gsa/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
+++ b/gsa/src/web/components/form/__tests__/__snapshots__/selectelement.js.snap
@@ -292,7 +292,10 @@ exports[`SelectContainer tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 100px;
 }
 
diff --git a/gsa/src/web/components/form/__tests__/__snapshots__/timezoneselect.js.snap b/gsa/src/web/components/form/__tests__/__snapshots__/timezoneselect.js.snap
index 42a94f9539..868d0160fe 100644
--- a/gsa/src/web/components/form/__tests__/__snapshots__/timezoneselect.js.snap
+++ b/gsa/src/web/components/form/__tests__/__snapshots__/timezoneselect.js.snap
@@ -87,7 +87,10 @@ exports[`TimezoneSelect tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 230px;
 }
 
diff --git a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/relationselector.js.snap b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/relationselector.js.snap
index 2bac4bafa7..a23777a2e2 100644
--- a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/relationselector.js.snap
+++ b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/relationselector.js.snap
@@ -87,7 +87,10 @@ exports[`Relation Selector Tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 
diff --git a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/severityvaluesgroup.js.snap b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/severityvaluesgroup.js.snap
index e0a8fa048a..85376b1a2f 100644
--- a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/severityvaluesgroup.js.snap
+++ b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/severityvaluesgroup.js.snap
@@ -187,7 +187,10 @@ exports[`Severity Values Group Tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 
diff --git a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/sortbygroup.js.snap b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/sortbygroup.js.snap
index a2ec74ffbc..85b650738b 100644
--- a/gsa/src/web/components/powerfilter/__tests__/__snapshots__/sortbygroup.js.snap
+++ b/gsa/src/web/components/powerfilter/__tests__/__snapshots__/sortbygroup.js.snap
@@ -187,7 +187,10 @@ exports[`SortByGroup tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 
diff --git a/gsa/src/web/entities/__tests__/__snapshots__/tagsdialog.js.snap b/gsa/src/web/entities/__tests__/__snapshots__/tagsdialog.js.snap
index 73169a12a1..9791430682 100644
--- a/gsa/src/web/entities/__tests__/__snapshots__/tagsdialog.js.snap
+++ b/gsa/src/web/entities/__tests__/__snapshots__/tagsdialog.js.snap
@@ -512,7 +512,10 @@ exports[`TagsDialog dialog component tests should disable tag selection when no
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 230px;
 }
 
@@ -1219,7 +1222,10 @@ exports[`TagsDialog dialog component tests should render dialog 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 230px;
 }
 
diff --git a/gsa/src/web/pages/tickets/__tests__/__snapshots__/createdialog.js.snap b/gsa/src/web/pages/tickets/__tests__/__snapshots__/createdialog.js.snap
index 9c0abe492e..c1b1f67ad2 100644
--- a/gsa/src/web/pages/tickets/__tests__/__snapshots__/createdialog.js.snap
+++ b/gsa/src/web/pages/tickets/__tests__/__snapshots__/createdialog.js.snap
@@ -441,7 +441,10 @@ exports[`CreateTicketDialog component tests should render dialog 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 
diff --git a/gsa/src/web/pages/tickets/__tests__/__snapshots__/editdialog.js.snap b/gsa/src/web/pages/tickets/__tests__/__snapshots__/editdialog.js.snap
index 51508ecb95..43a36de6bb 100644
--- a/gsa/src/web/pages/tickets/__tests__/__snapshots__/editdialog.js.snap
+++ b/gsa/src/web/pages/tickets/__tests__/__snapshots__/editdialog.js.snap
@@ -441,7 +441,10 @@ exports[`EditTicketDialog component tests should render dialog 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 180px;
 }
 

From 5540f0225a2812f3306bf7fadce4da07e190b10d Mon Sep 17 00:00:00 2001
From: Crystal Lai <crystal.lai@greenbone.net>
Date: Wed, 17 Jul 2019 10:51:05 +0200
Subject: [PATCH 4/5] Updated CHANGELOG.md

---
 CHANGELOG.md | 1 +
 1 file changed, 1 insertion(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e72210b163..42b915a27f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ## [Unreleased]
 
 ### Added
+- Added grow option to multiselect component [#1485](https://github.com/greenbone/gsa/pull/1485)
 - Add LogoutIcon [#1481](https://github.com/greenbone/gsa/pull/1481)
 - Added a component "SeverityValuesGroup" enabling user choose the relation they want [#1477](https://github.com/greenbone/gsa/pull/1477)
 - Added filter keywords owner, host, cvss base score, vulnerability and location to filter dialog on results page [#1472](https://github.com/greenbone/gsa/pull/1472)

From 1abf38274b227496e03c446743525a3146bcfda9 Mon Sep 17 00:00:00 2001
From: Crystal Lai <crystal.lai@greenbone.net>
Date: Wed, 17 Jul 2019 11:53:42 +0200
Subject: [PATCH 5/5] removed default grow=0

---
 .../form/__tests__/__snapshots__/multiselect.js.snap     | 9 ++++-----
 gsa/src/web/components/form/multiselect.js               | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap b/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
index 597f9c93b3..b21f2223df 100644
--- a/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
+++ b/gsa/src/web/components/form/__tests__/__snapshots__/multiselect.js.snap
@@ -113,11 +113,10 @@ exports[`MultiSelect component tests should render 1`] = `
   -webkit-flex-direction: column;
   -ms-flex-direction: column;
   flex-direction: column;
-  -webkit-box-flex: 0;
-  -webkit-flex-grow: 0;
-  -ms-flex-positive: 0;
-  flex-grow: 0;
-  position: relative;
+  -webkit-box-flex: position:relative;
+  -webkit-flex-grow: position:relative;
+  -ms-flex-positive: position:relative;
+  flex-grow: position:relative;
   width: 250px;
 }
 
diff --git a/gsa/src/web/components/form/multiselect.js b/gsa/src/web/components/form/multiselect.js
index 2a09a9fc8c..81f2d9530d 100644
--- a/gsa/src/web/components/form/multiselect.js
+++ b/gsa/src/web/components/form/multiselect.js
@@ -176,7 +176,7 @@ class MultiSelect extends React.Component {
       items,
       menuPosition = 'adjust',
       width = DEFAULT_WIDTH,
-      grow = '0',
+      grow,
     } = this.props;
 
     const {search, selectedItems} = this.state;