[7.0] Fix stop scan #414
Merged
[7.0] Fix stop scan #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only uses SIGUSR1 for stopping the current scan. SIGUSR2 was used before when the scanner was a daemon and and it was able to run multiple task. As handle_stop_all_scans_signal() was removed, a check is done within handle_scan_stop_signal() to differentiate the parent process and the child process.
The scanner delete the kb if the scan was stopped. Otherwise, during a normal host kb deletion just removes the connections. When the host scan process ends, set the "finishes" flag in redis before removing the host from the list. This avoid to set the end_time, after the kb was already clean out by the ospd-openvas process.
Don't delete the kb in the stop scan. This clean out must be done by ospd-openvas.
bjoernricks
approved these changes
Oct 24, 2019
mattmundell
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.