[7.0] Improve handling of invalid or existent ids of nvt's preference id. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnicola
force-pushed
the
timeout-id-7
branch
from
94b2999
to
2973e9e
Compare
It detects if the id is repeted. Also detects if the id 0 is beeing used, which is invalid because id 0 is reserved for the timeout preferences. Also detects if an id has a non-integer value.
jjnicola
force-pushed
the
timeout-id-7
branch
from
2973e9e
to
a90bd82
Compare
mattmundell
previously approved these changes
Oct 31, 2019
| { | ||
| nasl_perror (lexic, | ||
| "Invalid id or not allowed id value in the call to %s()\n", | ||
| __func__); |
There was a problem hiding this comment.
I think we should switch to __func__ everywhere, instead of mixing it with the existing uses of __FUNCTION__.
Co-Authored-By: Matt Mundell <32057441+mattmundell@users.noreply.github.com>
mattmundell
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It detects if the id is repeted.
Also detects if the id 0 is beeing used, which is invalid because id 0 is reserved
for the timeout preferences. Also detects if an id has a non-integer value.