Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send message to the client if the port list is not valid. #453

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

jjnicola
Copy link
Member

Also set the status to finished.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we should just add an error result, ignore the port and scan instead.

@jjnicola
Copy link
Member Author

jjnicola commented Feb 20, 2020

Not sure if we should just add an error result, ignore the port and scan instead.

Yes. I thought about that, but this will need a change in gvm-lib/networking.c:validate_port_range(), which is called by gvmd too.

@jjnicola jjnicola closed this Feb 20, 2020
@jjnicola jjnicola reopened this Feb 20, 2020
@bjoernricks bjoernricks self-requested a review February 20, 2020 14:58
@jjnicola jjnicola merged commit 8af8374 into greenbone:master Feb 24, 2020
@jjnicola jjnicola deleted the port-zero branch May 7, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants