Drop http sync #478
Merged
Drop http sync #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that rsync is the only availabl method and it is therefore mandatory, remove any handling of method selection via FIXED_METHOD. This simplifies some code parts.
The community sync routine is simplified. The check for rsync availability is done always priot to calling this function. Whioe doing tests, found out the help should mention exit code for selftest.
cfi-gb
reviewed
Apr 12, 2020
bjoernricks
previously requested changes
Apr 13, 2020
timopollmeier
approved these changes
Apr 29, 2020
timopollmeier
dismissed
bjoernricks’s stale review
@bjoernricks and I have agreed to go ahead with removing the sync scripts
|
The comment #478 (comment) from @cfi-gb should be considered in another pr |
|
A new PR for the suggestion #478 (comment) open: #488 |
Merged
|
Official announcement for this change: https://community.greenbone.net/t/shutting-down-gcf-http-download/5339 |
This was referenced Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes wget and curl options for feed download.
These methods always download the entire feed instead of just the delta like rsync does.
The command line options --rsync, --curl and --wget are removed.