-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timeout argument to ssh_connect() nasl function #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion timeout in seconds
jjnicola
force-pushed
the
ssh-timeout
branch
from
December 11, 2020 15:14
38fba69
to
743c23c
Compare
cfi-gb
suggested changes
Dec 12, 2020
jjnicola
force-pushed
the
ssh-timeout
branch
from
December 14, 2020 07:48
6a3e69e
to
e06367f
Compare
ArnoStiefvater
previously approved these changes
Dec 14, 2020
cfi-gb
suggested changes
Dec 14, 2020
jjnicola
force-pushed
the
ssh-timeout
branch
from
December 14, 2020 08:04
e06367f
to
5388d13
Compare
cfi-gb
reviewed
Dec 14, 2020
jjnicola
force-pushed
the
ssh-timeout
branch
from
December 14, 2020 10:40
5388d13
to
f2924d2
Compare
cfi-gb
reviewed
Dec 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the text / description changes.
cfi-gb
approved these changes
Dec 14, 2020
ArnoStiefvater
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Add timeout argument to ssh_connect() nasl function to set the connection timeout in seconds
Why:
Some ssh server take too long to return the prompt for the password
How:
As I didn't have a ssh server with the issue, I have used the paramiko server demo and added some sleep() before returning the prompt. That simulates the issue in the server side. Then, I used the next nasl script:
openvas-nasl -X -B -d -i /home/jnicola/install/var/lib/openvas/plugins -t localhost ssh_timeout.nasl
Checklist: