Skip to content

Commit

Permalink
Fix: Mark repo model properties for security and analysis as optional
Browse files Browse the repository at this point in the history
Despite the JSON schema doesn't mention the properties are optional it
seems they are actually optional. The property `advanced_security` is
missing in several of our responses and therefore we got a model error.
  • Loading branch information
bjoernricks committed Sep 27, 2023
1 parent 531ade7 commit 0ad99e9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pontos/github/models/organization.py
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,9 @@ class SecurityAndAnalysis(GitHubModel):
Protection is used
"""

advanced_security: SecurityAndAnalysisType
secret_scanning: SecurityAndAnalysisType
secret_scanning_push_protection: SecurityAndAnalysisType
advanced_security: Optional[SecurityAndAnalysisType] = None
secret_scanning: Optional[SecurityAndAnalysisType] = None
secret_scanning_push_protection: Optional[SecurityAndAnalysisType] = None


@dataclass
Expand Down

0 comments on commit 0ad99e9

Please sign in to comment.