Change: Improve error message when a model value can't be set

Make the error message more precise in what's wrong here actually.
greenbone · Sep 27, 2023 · c3d18b8 · c3d18b8
1 parent a31ae3c
commit c3d18b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/pontos/models/__init__.py b/pontos/models/__init__.py
@@ -163,8 +163,8 @@ def from_dict(cls, data: Dict[str, Any]):
                     value = cls._get_value(model_field_cls, value)  # type: ignore # pylint: disable=line-too-long # noqa: E501
             except TypeError as e:
                 raise ModelError(
-                    f"Error while creating {cls.__name__}. Could not set value "
-                    f"for '{name}' from '{value}'."
+                    f"Error while creating {cls.__name__} model. Could not set "
+                    f"value for property '{name}' from '{value}'."
                 ) from e
 
             if name in type_hints:

diff --git a/tests/models/test_models.py b/tests/models/test_models.py
@@ -205,7 +205,7 @@ class ExampleModel(Model):
 
         with self.assertRaisesRegex(
             ModelError,
-            "Error while creating ExampleModel. Could not set value for 'foo' "
-            "from '{'bar': 'baz'}'.",
+            "Error while creating ExampleModel model. Could not set value for "
+            "property 'foo' from '{'bar': 'baz'}'.",
         ):
             ExampleModel.from_dict({"foo": {"bar": "baz"}})