Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Codeship support #25

Closed
2 of 3 tasks
StephanBijzitter opened this issue May 25, 2017 · 7 comments
Closed
2 of 3 tasks

Add Codeship support #25

StephanBijzitter opened this issue May 25, 2017 · 7 comments

Comments

@StephanBijzitter
Copy link

StephanBijzitter commented May 25, 2017

Not sure if this is being worked on already, which is why I'm creating this issue.
Looking at the source, this is what will have to be done:

If this is all, I'll be able to do this sometime this week.

@boennemann
Copy link
Member

Hey @StephanBijzitter,

if you want to tackle this I'm more than happy to assist you with it. You're todo list looks exactly right though :)
I hope the way we implemented the CI service abstraction makes it somewhat easy for your to add this configuration.

Let me know how it goes. Looking forward to your PR 👍

Best,
Stephan

@StephanBijzitter
Copy link
Author

Started working on it already! Codeship does not seem to have as much information about pull requests immediately available through environment variables (as compared to Travis), so I'll have to resort to parsing the result of the command-line.

The way this repository is set up is definitely very nice!

Progress can be seen in my fork, and I'll migrate that pull request to this repository when it's finished.
https://github.com/StephanBijzitter/greenkeeper-lockfile/pull/1

@teriu
Copy link

teriu commented Sep 7, 2017

Any update on your PR? I see Codeship are still working on the CI_PULL_REQUEST var: https://community.codeship.com/t/populate-ci-pull-request/1053

@StephanBijzitter
Copy link
Author

Yeah it turned out to be more tricky than anticipated, so I moved it to our backlog. Good news though, because I (or someone in my team) will pick this up soon. Of course all help is welcome, but I think we'll able to fit this into the next sprint, or the one after that.

@selbyk
Copy link
Contributor

selbyk commented Oct 10, 2017

I opened a PR that we have been using for about a month: #72

@janl
Copy link
Contributor

janl commented Oct 18, 2017

Closing in favour of #72

@janl janl closed this as completed Oct 18, 2017
@ethangj
Copy link

ethangj commented Feb 19, 2019

Hey, there - a bit late, but I wanted to let y'all know that we now have this environment variable exposed on Codeship. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants