Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ref option for svgr #29

Merged
merged 3 commits into from
Dec 12, 2017
Merged

Add ref option for svgr #29

merged 3 commits into from
Dec 12, 2017

Conversation

lifeiscontent
Copy link
Contributor

Fixes #28

@codecov
Copy link

codecov bot commented Dec 11, 2017

Codecov Report

Merging #29 into master will decrease coverage by 1.95%.
The diff coverage is 28%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #29      +/-   ##
=========================================
- Coverage   41.75%   39.8%   -1.96%     
=========================================
  Files          21      22       +1     
  Lines         182     206      +24     
  Branches       41      49       +8     
=========================================
+ Hits           76      82       +6     
- Misses         84      96      +12     
- Partials       22      28       +6
Impacted Files Coverage Δ
src/index.js 100% <ø> (ø) ⬆️
src/cli/index.js 0% <ø> (ø) ⬆️
src/transforms/wrapIntoNativeComponent.js 13.33% <0%> (-11.67%) ⬇️
src/configToOptions.js 86.95% <100%> (+0.59%) ⬆️
src/h2x/svgRef.js 11.11% <11.11%> (ø)
src/transforms/wrapIntoComponent.js 62.5% <62.5%> (-37.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82023ad...cf19d12. Read the comment docs.

@gregberge
Copy link
Owner

Thanks! Can you please document it in config section of readme?

@lifeiscontent
Copy link
Contributor Author

@neoziro updated.

@gregberge gregberge merged commit 86e0bda into gregberge:master Dec 12, 2017
@gregberge
Copy link
Owner

Thanks! Released as v1.5.0 🎉

@lifeiscontent lifeiscontent deleted the patch-4 branch December 12, 2017 14:55
@lifeiscontent
Copy link
Contributor Author

@neoziro thanks for being an awesome maintainer ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants