Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is viewBox stripped (by default)? #324

Closed
avwie opened this issue Jul 15, 2019 · 5 comments
Closed

Why is viewBox stripped (by default)? #324

avwie opened this issue Jul 15, 2019 · 5 comments

Comments

@avwie
Copy link

avwie commented Jul 15, 2019

In the settings for SVGO, the viewBox is stripped by default? What is the reasoning behind this, because it breaks proper scaling. I have difficulty to understand why the viewBox should be stripped in the first place? I have never encountered a situation where I didn't want the viewBox.

@gregberge
Copy link
Owner

Hello @avwie, you should ask SVGO team about that.

@avwie
Copy link
Author

avwie commented Jul 15, 2019

That is weird, why should I ask them? It is just a library feature of SVGO. Why have you enabled it as default behavior in SVGR, breaking proper scaling? That is the question. It is just a setting of SVGO, but you opted to enable it by default. The question is why? Is there something I am missing?

@gregberge
Copy link
Owner

I don't want to override the default from SVGO. So I rely on SVGO default in SVGR.

@3610cn
Copy link

3610cn commented Aug 27, 2019

so what should i do to make proper scaling?

@gregberge
Copy link
Owner

You can add a SVGO config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants