Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserveComments with templates #660

Closed
tu4mo opened this issue Dec 31, 2021 · 1 comment · Fixed by #661
Closed

preserveComments with templates #660

tu4mo opened this issue Dec 31, 2021 · 1 comment · Fixed by #661

Comments

@tu4mo
Copy link
Contributor

tu4mo commented Dec 31, 2021

🚀 Feature Proposal

Enable preserveComments by default in templates.

Motivation

With new template syntax, it's difficult to enable preserveComments.

Pitch

preserveComments should be enabled by default, since we control the content of the template anyway. It's unexpected that comments gets stripped out in the final result.
@open-collective-bot
Copy link

Hey @tu4mo 👋,
Thank you for opening an issue. We'll get back to you as soon as we can.
Please, consider supporting us on Open Collective. We give a special attention to issues opened by backers.
If you use SVGR at work, you can also ask your company to sponsor us ❤️.

@tu4mo tu4mo mentioned this issue Jan 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support comments in templates
1 participant
@tu4mo