This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
Change tests to use standard library, more idiomatic style. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation for using idiomatic style and standard library for tests is that it's more universal, and more familiar to a larger set of people. It makes it easier to read, modify tests for experienced Go programmers. It does not require thorough knowledge and familiarity with custom APIs. Resolves #41. This commit is largely based on previous work by @uovobw in #3, modified by me to improve error messages, style, and address preliminary review comments.
|
@gregjones I believe this should be good to merge. Have you had a chance to review it, and are there any review comments I should address? |
|
Hi, it looks good, thanka for aortibg it. but I still only have mobile internet, so might be a while before I can do anything with it... If anyone else is paying attention and wants to comment then I might be happier pressing buttons without being able to verify things myself :/ |
|
Friendly ping. I'd like to make progress, is there anything I can do to help get this merged? |
|
I am still away from home. Sorry :/ |
|
Back at home now, with a laptop! Thank you for your patience. |
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for using idiomatic style and standard library for tests is that it's more universal, and more familiar to a larger set of people. It makes it easier to read, modify tests for experienced Go programmers. It does not require thorough knowledge and familiarity with custom APIs.
Resolves #41.
This commit is largely based on previous work by @uovobw in sourcegraph#3, modified by me to improve error messages, style, and address preliminary review comments.