Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Add BoltDB implementation to Readme #78

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Add BoltDB implementation to Readme #78

merged 2 commits into from
Nov 2, 2017

Conversation

gregjones
Copy link
Owner

cc @birkelund - I'll add your package to the list in the readme, thanks for letting us now

@gregjones gregjones requested a review from dmitshur October 4, 2017 20:28
Copy link
Collaborator

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick about missing period. Otherwise LGTM.

README.md Outdated
@@ -17,6 +17,7 @@ Cache Backends
- [`github.com/gregjones/httpcache/leveldbcache`](https://github.com/gregjones/httpcache/tree/master/leveldbcache) provides a filesystem-backed cache using [leveldb](https://github.com/syndtr/goleveldb/leveldb).
- [`github.com/die-net/lrucache`](https://github.com/die-net/lrucache) provides an in-memory cache that will evict least-recently used entries.
- [`github.com/die-net/lrucache/twotier`](https://github.com/die-net/lrucache/tree/master/twotier) allows caches to be combined, for example to use lrucache above with a persistent disk-cache.
- [`github.com/birkelund/boltdbcache`](https://github.com/birkelund/boltdbcache) provides a BoltDB implementation (based on the [bbolt](https://github.com/coreos/bbolt) fork)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike all other entries above, this sentence is missing a period at the end.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll apply the change and merge this. (Let me know if any objections to me doing that @gregjones, for my future reference.)

For consistency with all other entries.
@dmitshur dmitshur merged commit 22a0b1f into master Nov 2, 2017
@dmitshur dmitshur deleted the gregjones-patch-1 branch November 2, 2017 01:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants