Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easing justified text at end of final line #1110

Closed
eroux opened this issue May 17, 2016 · 2 comments
Closed

easing justified text at end of final line #1110

eroux opened this issue May 17, 2016 · 2 comments

Comments

@eroux
Copy link
Contributor

eroux commented May 17, 2016

The following example:

\documentclass[11pt]{article} %%
\usepackage{fontspec} %%
\usepackage{gregoriotex} %%
\gresetlastline{justified}
\begin{document} %%

a\label{reprise}\par

\newcommand{\Ruber}[1]{\textit{\textcolor{gregoriocolor}{#1}}}

\gabcsnippet{%
(c4) Com(g)mu(h)ni(h)cán(h)tes,(h) et(h) di(h)em(h) sa(h)cra(h)tís(h)si(h)mum(h) ce(h)le(h)brán(h)tes,(h) (,) quo(h) U(h)ni(h)gé(h)ni(h)tus(h)  +(;) (g+) ([ev:\hfil]) <v>\Ruber{Sequitur p. \pageref{reprise}.}</v>{}()%
}%

\end{document}

bug

in which the right alignment is not correct.

@rpspringuel
Copy link
Contributor

That would be a bug in the end of line shifts. \greseteolshifts{disable} makes the problem disappear. Further, giving the last "syllable" a note, also fixes the problem, so it is particular to lines which end with a \GreNoNoteSyllable. It's too late tonight, but I'll look at the possibility of killing the eolshift in these cases tomorrow.

@rpspringuel
Copy link
Contributor

I have a fix, but it's revealing a potential problem with the clef change discretionary. Take a look at /gabc-output/glyphs/clef_change. If you compile the gabc file, you'll see that the clef change which occurs between test4 and test5 puts an empty BarSyllable at the end of the line (after test4). This prevents the lyrics in the previous syllable (i.e. test4) from sliding over under the end of line custos. My fix accentuates this, pushing test4 even further away from the end of the line. This doesn't seem to be desirable to me, but I think the problem is with the underlying behavior: what is put in the discretionary. Should that empty BarSyllable be there? Shouldn't there be some recognition that there isn't anything to be printed and the before break argument be left blank?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants