Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting GridapSolvers to PArrays v0.3 #30

Closed
amartinhuertas opened this issue Jul 23, 2023 · 2 comments · Fixed by #31
Closed

Porting GridapSolvers to PArrays v0.3 #30

amartinhuertas opened this issue Jul 23, 2023 · 2 comments · Fixed by #31
Assignees

Comments

@amartinhuertas
Copy link
Member

Please, before carrying this work take into account the following:

I have ported RedistributeTools.jl from GridapSolvers.jl to PArrays v0.3 and put it temporarily into GridapP4est.jl. Thus, PLEASE, when porting GridapSolvers.jl to PArrays v0.3 let us start from here. On the other hand, I am positive that the contents of RedistributeTools.jl should go to GridapDistributed.jl. We will also need mock tests, though.

See also gridap/GridapP4est.jl#35 and https://github.com/gridap/GridapP4est.jl/blob/p4est-migration-exploring-non-conformity/src/RedistributeTools.jl for more details

@JordiManyer
Copy link
Member

@amartinhuertas Yes, I will get on it. I agree with your comments.

On the other hand, I am positive that the contents of RedistributeTools.jl should go to GridapDistributed.jl. We will also need mock tests, though.

Concerning this: Should we try to release GridapDistributed v0.3, then patch it with these changes and finally port GridapSolvers? Or should I port GridapSolvers beforehand and then patch both repositories with these changes?

@amartinhuertas
Copy link
Member Author

Concerning this: Should we try to release GridapDistributed v0.3, then patch it with these changes and finally port GridapSolvers? Or should I port GridapSolvers beforehand and then patch both repositories with these changes?

We should tightly coordinate how to proceed with the releases of GridapDistributed and GridapSolvers. I would try that the new releases include both the porting to PArrays v0.3 and the refactoring (i.e., transferring code from GridapSolvers and GridapP4est to GridapDistributed).

@JordiManyer JordiManyer linked a pull request Aug 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants