Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeMeasure integration now working properly in some cases #8

Closed
JordiManyer opened this issue Feb 20, 2023 · 2 comments · Fixed by #9
Closed

CompositeMeasure integration now working properly in some cases #8

JordiManyer opened this issue Feb 20, 2023 · 2 comments · Fixed by #9
Assignees
Labels
bug Something isn't working

Comments

@JordiManyer
Copy link
Member

JordiManyer commented Feb 20, 2023

I think I've found the bug that makes the number of CG iterations go up when increasing the number of refinement levels:

When refining a mesh, P4est seems to not keep all fine cells born from a coarse cell in the same processor... We can then have, for a certain coarse cell, half it's children in one processor and the other half in another one (even before redistribution). The coarse meshes then tend to overlap.

This is a problem for our current implementation when using CompositeMeasures, where each processor containing children for a certain coarse cell ends up in possession of some (but not all) the fine contributions corresponding to that coarse cell. We then end up with incomplete contributions in both processors, and therefore the integration is wrong...

I've pushed some changes showcasing the issue into a new branch and will try to solve this over the next few days.

@JordiManyer
Copy link
Member Author

Update:
The problem comes from the fact that DistributedTriangulations use views over the full model triangulation to get rid of ghost cells. Views were not yet supported from Gridap, causing some issues.

Some changes have been introduced in d6a53e3 to resolve this.

@JordiManyer
Copy link
Member Author

Solved by #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant