From bf63f43ab7a643c4a43d0813f658568a9aca4f36 Mon Sep 17 00:00:00 2001 From: barton26 Date: Mon, 1 Aug 2022 16:03:07 -0400 Subject: [PATCH] Define MAX_DIGITS_BTC for magic number in BitcoinUnits::format --- src/qt/bitcoinunits.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qt/bitcoinunits.cpp b/src/qt/bitcoinunits.cpp index fd713fcd7e..baf3a6cd30 100644 --- a/src/qt/bitcoinunits.cpp +++ b/src/qt/bitcoinunits.cpp @@ -3,6 +3,8 @@ #include +static constexpr auto MAX_DIGITS_BTC = 16; + BitcoinUnits::BitcoinUnits(QObject *parent): QAbstractListModel(parent), unitlist(availableUnits()) @@ -99,7 +101,9 @@ QString BitcoinUnits::format(int unit, qint64 n, bool fPlus, bool justify) qint64 remainder = n_abs % coin; QString quotient_str = QString::number(quotient); - if (justify) quotient_str = quotient_str.rightJustified(16 - num_decimals, ' '); + if (justify) { + quotient_str = quotient_str.rightJustified(MAX_DIGITS_BTC - num_decimals, ' '); + } QString remainder_str = QString::number(remainder).rightJustified(num_decimals, '0');