Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom_components.hacs.exceptions.HacsException: No manifest.json file found '/manifest.json' #16

Open
grinco opened this issue Jan 21, 2024 · 11 comments

Comments

@grinco
Copy link
Owner

grinco commented Jan 21, 2024

I can't wrap my head around why hacs keeps complaining that manifest.json is missing. @yardee did you have any similar issues when you changed the directory structure?

Also there are a few things on the todo: fix github actions, especially the build and upload zip file process. I have no experience with it so it might take a little while before I figure it out.

@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

https://github.com/grinco/ote_rate/releases/tag/v0.2.2 is marked as beta for now until update is fixed.

@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

Looks like it has something to do with hacs caching. If I set v0.2.2 as latest, remove repository and re-add it hacs - it's updating just fine. I'll try to downgrade and update again. If it works - will resolve this one.

@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

Yup, I was able to validate the suspected behavior by downgrading to https://github.com/grinco/ote_rate/releases/tag/v0.2.0 and back to v.0.2.2.

TL;DR: looks like HACS doesn't handle well changing "content_in_root" between releases. To work around it one must remove the repository from HACS and re-add, or install the update manually. I'll collect all necessary logs and report a bug against HACS.

@grinco grinco closed this as completed Jan 21, 2024
@yardee
Copy link
Collaborator

yardee commented Jan 21, 2024

I have no issues with upgrading to new structure, but it might be just thanks to I had to change the respository to my fork anyway. Build action looks good now right?

@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

For some reason it's not triggered. See, I have just published https://github.com/grinco/ote_rate/releases/tag/v0.2.3 and the build workflow didn't trigger. I'll give it a try on a dummy repo and will fix when I have time. For now I've updated the ZIP manually and attached to the release.

@grinco grinco reopened this Jan 21, 2024
@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

Found the issue with the build process. It only works when the release is published using the CLI.

@grinco grinco closed this as completed Jan 21, 2024
@yardee
Copy link
Collaborator

yardee commented Jan 21, 2024

Thats strange, I have tried it on my fork and it triggered successfully: https://github.com/yardee/ote_rate/actions/workflows/build.yaml (just needed to set rights to write)

@yardee
Copy link
Collaborator

yardee commented Jan 21, 2024

Also I found out checks on pull requests are not triggered. Like here
https://github.com/yardee/ote_rate/pull/9/checks
https://github.com/yardee/ote_rate/actions/workflows/pull.yml

@yardee
Copy link
Collaborator

yardee commented Jan 21, 2024

I think I have just setup Branch protection rules in the repository settings

@grinco grinco reopened this Jan 21, 2024
@grinco
Copy link
Owner Author

grinco commented Jan 21, 2024

It's because your pull request introduced the actions - it didn't exist in the repo before. It works now. Here's an example:
https://github.com/grinco/ote_rate/actions/runs/7604215259
https://github.com/grinco/ote_rate/pull/18/checks

@yardee
Copy link
Collaborator

yardee commented Jan 22, 2024

Sure, I ment on this PR, where were pull request actions already merged. But it doesn't matter, it is working now. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants