From c271895205ba3b68d60997d97c8a96fbb5f51644 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 30 Jul 2019 00:01:02 +0900 Subject: [PATCH 1/4] :warning: ambiguous first argument; put parentheses or a space even after `/' operator --- spec/parallel_tests/gherkin/runner_behaviour.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/parallel_tests/gherkin/runner_behaviour.rb b/spec/parallel_tests/gherkin/runner_behaviour.rb index 558edd44..546bb334 100644 --- a/spec/parallel_tests/gherkin/runner_behaviour.rb +++ b/spec/parallel_tests/gherkin/runner_behaviour.rb @@ -15,7 +15,7 @@ def call(*args) it "allows to override runner executable via PARALLEL_TESTS_EXECUTABLE" do ENV['PARALLEL_TESTS_EXECUTABLE'] = 'script/custom_rspec' - should_run_with /script\/custom_rspec/ + should_run_with(/script\/custom_rspec/) call(['xxx'], 1, 22, {}) end From 97598195c603a14b97e32343d735a66d397c930b Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 30 Jul 2019 00:03:31 +0900 Subject: [PATCH 2/4] :warning: method redefined `pids` method is redefined at line 34 --- lib/parallel_tests/pids.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/parallel_tests/pids.rb b/lib/parallel_tests/pids.rb index 025182aa..eb6b4c43 100644 --- a/lib/parallel_tests/pids.rb +++ b/lib/parallel_tests/pids.rb @@ -2,7 +2,7 @@ module ParallelTests class Pids - attr_reader :pids, :file_path, :mutex + attr_reader :file_path, :mutex def initialize(file_path) @file_path = file_path From 48abe7269fa1108232d1ecdd12fedb423c8aa878 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 30 Jul 2019 00:04:40 +0900 Subject: [PATCH 3/4] :warning: assigned but unused variable - out --- spec/parallel_tests/test/runner_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/parallel_tests/test/runner_spec.rb b/spec/parallel_tests/test/runner_spec.rb index f5f3d73d..502fe07f 100644 --- a/spec/parallel_tests/test/runner_spec.rb +++ b/spec/parallel_tests/test/runner_spec.rb @@ -475,7 +475,7 @@ def run_with_file(content) it "prints each stream to the correct stream" do skip "open3" - out, err = run_with_file("puts 123 ; $stderr.puts 345 ; exit 5") do |path| + _out, err = run_with_file("puts 123 ; $stderr.puts 345 ; exit 5") do |path| result = call("ruby #{path}", 1, 4, {}) expect(result).to include({ :stdout => "123\n", From 636ca65c8b8434efff7e9904f6a12130e29de730 Mon Sep 17 00:00:00 2001 From: Akira Matsuda Date: Tue, 30 Jul 2019 00:07:18 +0900 Subject: [PATCH 4/4] :warning: instance variable @feature, @ignore_tag_pattern not initialized --- lib/parallel_tests/gherkin/listener.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/parallel_tests/gherkin/listener.rb b/lib/parallel_tests/gherkin/listener.rb index 368e940c..57fdbfff 100644 --- a/lib/parallel_tests/gherkin/listener.rb +++ b/lib/parallel_tests/gherkin/listener.rb @@ -10,6 +10,7 @@ class Listener def initialize @steps, @uris = [], [] @collect = {} + @feature, @ignore_tag_pattern = nil reset_counters! end