-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow spring to be force enabled #469
Conversation
@@ -246,6 +246,7 @@ TIPS | |||
- [Distributed parallel test (e.g. Travis Support)](https://github.com/grosser/parallel_tests/wiki/Distributed-Parallel-Tests-and-Travis-Support) | |||
- Debug errors that only happen with multiple files using `--verbose` and [cleanser](https://github.com/grosser/cleanser) | |||
- Shell alias: `alias prspec='parallel_rspec -m 2 --'` | |||
- [Spring] to use spring you have to [patch it](https://github.com/grosser/parallel_tests/wiki) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just link directly to https://github.com/grosser/parallel_tests/wiki/Spring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another suggestion: Instead of maintaining the code on the wiki, put it in the code base, and require "parallel_tests/spring_config" if defined?(::Spring)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users will most likely have to reset redis + memcached + solr etc ... so
I'm afraid the solution won't work for everyone ... so something like
require 'parallel_tests/spring'
Parallel::Spring.reconnect do
ActiveRecord::Base.reconnect!
end
might be a better approach ... but that's for another PR
On Fri, Dec 4, 2015 at 6:14 AM, betesh notifications@github.com wrote:
In Readme.md
#469 (comment):@@ -246,6 +246,7 @@ TIPS
- Distributed parallel test (e.g. Travis Support)
- Debug errors that only happen with multiple files using
--verbose
and cleanser- Shell alias:
alias prspec='parallel_rspec -m 2 --'
- - [Spring] to use spring you have to patch it
Another suggestion: Instead of maintaining the code on the wiki, put it in
the code base, and require "parallel_tests/spring_config" if
defined?(::Spring)—
Reply to this email directly or view it on GitHub
https://github.com/grosser/parallel_tests/pull/469/files#r46685247.
aec41bc
to
584bccd
Compare
allow spring to be force enabled
2.2.1 |
No description provided.