Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After update to 4.1.0 binding.pry dont work on parallel_tests #890

Closed
T00595 opened this issue Feb 2, 2023 · 3 comments
Closed

After update to 4.1.0 binding.pry dont work on parallel_tests #890

T00595 opened this issue Feb 2, 2023 · 3 comments

Comments

@T00595
Copy link

T00595 commented Feb 2, 2023

After update my version for 4.1.0 binding.pry dont work on parallel_tests on terminal console, before this version this work normaly. The terminal does not allow to type.

In version 4.0.0
image

In Version 4.1.0
image

@grosser
Copy link
Owner

grosser commented Feb 4, 2023

reproduction:

# Gemfile
source "https://rubygems.org"

gem "parallel_tests", path: "~/Code/tools/parallel_tests"
gem "minitest"

# test/a_test.rb
require "minitest/autorun"

describe "foo" do
  it "do" do
    # binding.irb
    puts "foo"
    sleep 10
  end
end

trap("SIGINT")  do
  puts "GOT INT"
  $stdout.flush
end

with pgroup we get 1 "GOT INT" but binding.irb does not work
without pgroup we get 2 "GOT INT" but binding.irb works

@grosser
Copy link
Owner

grosser commented Feb 4, 2023

#891 might fix it ... but also good chance it breaks CI runs that get interrupted ... will play with that a bit more

@grosser
Copy link
Owner

grosser commented Feb 6, 2023

v4.2.0

@grosser grosser closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants