Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large PR with merge conflicts doesn't automatically fail #220

Open
aheuermann opened this issue Jan 21, 2016 · 0 comments
Open

Large PR with merge conflicts doesn't automatically fail #220

aheuermann opened this issue Jan 21, 2016 · 0 comments

Comments

@aheuermann
Copy link
Contributor

We had an odd case today where a rather large PR had merge conflicts but the dotci job still ran. Typically the job fails on checkout at git fetch origin '+refs/pull/<PR #>/merge:', but in this case the job ran, with what I assume was old code.

It looks like the github api determines merge-ability asynchronously. Which I'm wondering if this is also what updates refs/pull/<PR #>/merge, but not sure...

Doing some digging, other jenkins github plugins don't look at mergeable or mergeable_state, but I did notice that travis-ci loops and checks before triggering the build.

Anyway, I think the build should fail if there are merge conflicts. Do you think it is worth adding a similar check to dotci?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant