Skip to content
This repository has been archived by the owner on Dec 26, 2019. It is now read-only.

Non-root Docker image #8

Open
skomma opened this issue Jul 10, 2018 · 1 comment
Open

Non-root Docker image #8

skomma opened this issue Jul 10, 2018 · 1 comment
Assignees

Comments

@skomma
Copy link

skomma commented Jul 10, 2018

Currently, this docker image runs as root.
But described in the official documentation, I think it would be better that this image runs as a non-root user.

Additionally, it is very helpful to install "tini" described in Handling Kernel Signals when running Growi on k8s cluster.

@yuki-takei
Copy link
Contributor

@skomma

Currently, this docker image runs as root.
But described in the official documentation, I think it would be better that this image runs as a non-root user.

We'll fix it.

Additionally, it is very helpful to install "tini" described in Handling Kernel Signals when running Growi on k8s cluster.

I think this image is not needed to use tini because this uses jwilder/dockerize and it seems to support SIGTERM.
(see jwilder/dockerize#12 (comment))

@yuki-takei yuki-takei self-assigned this Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants