Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Use tools/copyright and add our own COPYRIGHT headers #389

Closed
bwplotka opened this issue Jan 29, 2021 · 5 comments
Closed

v2: Use tools/copyright and add our own COPYRIGHT headers #389

bwplotka opened this issue Jan 29, 2021 · 5 comments
Assignees
@yashrsharma44
Labels
v2

Comments

@bwplotka
Copy link
Collaborator

bwplotka commented Jan 29, 2021 •
edited
Loading

Example copyright we could use:

// Copyright (c) The go-grpc-middleware Authors.
// Licensed under the Apache License 2.0.

I would recommend using https://github.com/efficientgo/tools#githubcomefficientgotoolscopyright -> it's easy to setup, we use it slowly everywhere (:
@bwplotka
Copy link
Collaborator Author

cc @yashrsharma44 @MalloZup if you have time 🤗

@bwplotka bwplotka added the v2 label Jan 29, 2021
@yashrsharma44
Copy link
Collaborator

Can take this issue if @MalloZup isn't taking 😁

@MalloZup
Copy link
Contributor

@yashrsharma44 go ahead. 🌻

I want to carry over the thanos implementation of rate-limit within the middleware 🐎

@yashrsharma44 yashrsharma44 mentioned this issue Apr 26, 2021
Merged
@yashrsharma44
Copy link
Collaborator

Added a PR for the same, let me know if the changes make sense :)

@yashrsharma44
Copy link
Collaborator

Resolved by #420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashrsharma44 yashrsharma44

Labels
v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bwplotka @MalloZup @yashrsharma44