Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling default response rendering in bazel rule #4123

Closed
rajukrishnamurthy opened this issue Mar 19, 2024 · 1 comment · Fixed by #4126
Closed

Support disabling default response rendering in bazel rule #4123

rajukrishnamurthy opened this issue Mar 19, 2024 · 1 comment · Fixed by #4126
Labels
enhancement

Comments

@rajukrishnamurthy
Copy link
Contributor

🚀 Feature

Disable default response was already implemented in pull/3006, however, this is not surfaced in the protoc_gen_openapiv2 rule.

I believe this might be relatively trivial and I've attached a patch.
@johanbrandhorst johanbrandhorst mentioned this issue Mar 19, 2024
Merged
@johanbrandhorst
Copy link
Collaborator

Hi, thanks for your issue. Please feel free to just open a PR with the patch :).

@rajukrishnamurthy rajukrishnamurthy mentioned this issue Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bazel): surface --disable_default_responses in rule def
2 participants
@johanbrandhorst @rajukrishnamurthy