Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxMessageLength #659

Open
farhodyusupov opened this issue Aug 17, 2023 · 7 comments
Open

MaxMessageLength #659

farhodyusupov opened this issue Aug 17, 2023 · 7 comments
Labels
type-enhancement

Comments

@farhodyusupov
Copy link

farhodyusupov commented Aug 17, 2023 •
edited
Loading

Is there any way to set up MaxMessageLength?
@mosuem
Copy link
Contributor

mosuem commented Aug 21, 2023

No, but please feel free to file a PR to implement this in ChannelOptions.

@farhodyusupov
Copy link
Author

can you suggest something to start with?

@mosuem
Copy link
Contributor

mosuem commented Aug 28, 2023

@jtattermusch I couldn't find any specs for this feature. Do specs for this exist, or is there a reference implementation?

@mraleph
Copy link
Member

mraleph commented Aug 28, 2023

@mosuem I think this is about configuring CodedBufferReader's sizeLimit.

@jtattermusch
Copy link
Contributor

jtattermusch commented Aug 28, 2023 •
edited
Loading

@jtattermusch I couldn't find any specs for this feature. Do specs for this exist, or is there a reference implementation?

This is what's done for C-core: https://github.com/grpc/grpc/blob/12c97481349d88852490a4acd0b5a0f9301d5b6c/include/grpc/impl/channel_arg_names.h#L37
https://github.com/grpc/grpc/blob/12c97481349d88852490a4acd0b5a0f9301d5b6c/include/grpc/impl/channel_arg_names.h#L43

grpc-java would have something similar.

@farhodyusupov
Copy link
Author

thank you, If I could succeed I will send pull request

@farhodyusupov
Copy link
Author

@mosuem I think this is about configuring CodedBufferReader's sizeLimit.

I didn`t work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mraleph @jtattermusch @mosuem @farhodyusupov