Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test: Test/GoAwayThenClose #5663

Closed
zasweq opened this issue Sep 21, 2022 · 3 comments
Closed

flaky test: Test/GoAwayThenClose #5663

zasweq opened this issue Sep 21, 2022 · 3 comments
Labels
fixit P2 Type: Testing

Comments

@zasweq
Copy link
Contributor

zasweq commented Sep 21, 2022

https://github.com/zasweq/grpc-go/actions/runs/3099894871/jobs/5019571243
@zasweq
Copy link
Contributor Author

zasweq commented Oct 14, 2022

https://github.com/grpc/grpc-go/actions/runs/3253038132/jobs/5339910147

@dfawley
Copy link
Member

dfawley commented Nov 28, 2022

#5293

@dfawley dfawley closed this as completed Nov 28, 2022
@easwars
Copy link
Contributor

easwars commented Nov 28, 2022

I can repro this on google3. About 7/100k times flakes. I think the test needs a bit of rewriting to ensure that when it fails, it fails fairly quickly. Now, the test just hangs until the go test timeout kicks in.

@easwars easwars added the fixit label Nov 28, 2022
This was referenced Nov 28, 2022
Closed
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
fixit P2 Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@easwars @dfawley @zasweq