Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported var/type/method missing comment #6942

Closed
arvindbr8 opened this issue Jan 24, 2024 · 0 comments · Fixed by #6972
Closed

Exported var/type/method missing comment #6942

arvindbr8 opened this issue Jan 24, 2024 · 0 comments · Fixed by #6972
Assignees
Labels
P2 Type: Documentation Documentation or examples

Comments

@arvindbr8
Copy link
Member

Found a couple of linter issues from the patch set in #6915 during our weekly import

  1. missing comment on the following exported type/method

func (fcm *FilterChainManager) FilterChains() []*FilterChain {

type UsableRouteConfiguration struct {

  1. There is a typo in the comment s/TriggerXDSResourceNotFoundClient/TriggerXDSResourceNameNotFoundClient/

// TriggerXDSResourceNotFoundClient invokes the testing xDS Client singleton

@arvindbr8 arvindbr8 added the Type: Documentation Documentation or examples label Jan 24, 2024
@ginayeh ginayeh added the P2 label Feb 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants