-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test: TestClientSendsAGoAway #7160
Comments
|
@arvindbr8 This seems to be working for me. I ran the following commands to cross check and all of'em worked. Let me know in case i am missing something
|
@arvindbr8 I assigned it back to you since @aranjans needs more clarification. Let me know if its ok |
Sure. We discussed this offline: It's usually hard to reproduce these flakes that occur in GitHub CI on local. This is because, usually since our laptops have more juice than the free GitHub VMs that we use. Traditionally, we have an internal mechanism (discussed in chat with @aranjans) which would allow us to run the test in the order of 10-100K runs to check for flake rate. Once we have the flake rate, we can decide the priority of this issue. Regardless imo, this is worth taking a look now since this was checked very recently by @aranjans and he has not so stale context on the test that he added. |
@aranjans -- please let me know if you want to sync up again regarding the mechanism mentioned above. |
Closing this issue as we are not able to repro this. |
Encountered another failure: https://github.com/grpc/grpc-go/actions/runs/9018295431/job/24778588175?pr=7184 |
Here is a repro of the race condition: https://github.com/grpc/grpc-go/compare/master...arjan-bal:repro-race-cond?expand=1 We should probably wait for the client's Channel to be READY before closing it. |
This is the first time I'm seeing it:
https://github.com/grpc/grpc-go/actions/runs/8787418013/job/24112571687?pr=7156
Might be worth to check it out.
The text was updated successfully, but these errors were encountered: