Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: MD.String should only show metadata known to not contain tokens or other PII #7395

Open
dfawley opened this issue Jul 8, 2024 · 1 comment
Open

metadata: MD.String should only show metadata known to not contain tokens or other PII #7395

dfawley opened this issue Jul 8, 2024 · 1 comment
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. P1 Status: Blocked Type: Security A bug or other problem affecting security

Comments

@dfawley
Copy link
Member

dfawley commented Jul 8, 2024

Unfortunately, we know this change will break etcd, so it should not be done yet. (See: https://github.com/etcd-io/etcd/blob/21e5876f7f0539509c277b4c2a3ba1b1599b1721/client/v3/watch.go#L1038-L1043.) I will file an issue in the etcd repo and link it here.
@dfawley dfawley added P1 Type: Security A bug or other problem affecting security labels Jul 8, 2024
@dfawley dfawley mentioned this issue Jul 8, 2024
Closed
4 tasks
@dfawley
Copy link
Member Author

dfawley commented Jul 16, 2024

Update: the changes have been made to etcd to stop relying on this, and have been backported to release branches, but we still need to wait for their releases before implementing anything.

@arjan-bal arjan-bal added the Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: RPC Features Includes Compression, Encoding, Attributes/Metadata, Interceptors. P1 Status: Blocked Type: Security A bug or other problem affecting security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfawley @arjan-bal