Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: propagate previously received errors to new watchers #7819

Closed
easwars opened this issue Nov 6, 2024 · 1 comment
Closed

xdsclient: propagate previously received errors to new watchers #7819

easwars opened this issue Nov 6, 2024 · 1 comment
Assignees
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Nov 6, 2024

Currently when an authority is notified about events on a watched resource, the following happens:

  • when a good update is received, the resource cache is updated and existing watchers are notified about the update
    • if a new watch is registered for this resource in the future, it will immediately get the most recent update
  • when a bad update is received (i.e. one that is NACKed), the metadata field in the resource cache is updated with the error, and all existing watchers are notified about the error. The resource cache persists the old good resource (if one exists)
    • if a new watch is registered for this resource in the future, it will immediately get the most recent update (if one exists)
    • but it never gets the cached error
  • when a resource not found error is received, the resource cache is cleared of the previous resource (if one exists), and the metadata field is updated to indicate that the management server does not have this resource. All existing watchers are notified that the resource does not exist on the management server.
    • if a new watch is registered for this resource in the future, it will simply hang

We need to fix the code to handle the NACK and resource-not-found case for new watchers, and add appropriate tests for these scenarios.

@easwars easwars assigned easwars and purnesh42H and unassigned easwars Nov 6, 2024
@purnesh42H
Copy link
Contributor

Ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Bug
Projects
None yet
Development

No branches or pull requests

2 participants