Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded embededd OkHttp library to latest version, 3.14.9 #7324

Closed
mformetal opened this issue Aug 12, 2020 · 2 comments
Closed

Upgraded embededd OkHttp library to latest version, 3.14.9 #7324

mformetal opened this issue Aug 12, 2020 · 2 comments

Comments

@mformetal
Copy link

Is your feature request related to a problem?

Not necessarily a problem, but the app I work in uses Retrofit, which as of creating this PR uses version 3.14.9 of OkHttp: https://github.com/square/retrofit/blob/master/build.gradle#L7.

Describe the solution you'd like

I'd like to see if upgrading grpc-java's version of OkHttp to 3.14.9 causes any breaking changes.

Describe alternatives you've considered

I've excluded the embedded version of OkHttp that grpc-okhttp brings in, but it was requested of me to try and get the library aka grpc-java to upgrade internally.

@sanjaypujare
Copy link
Contributor

sanjaypujare commented Aug 12, 2020

@mformetal can you clone and build grpc-java yourself after locally upgrading the okhttp version (from the current 2.7.4) to 3.14.9 and see if causes any breaking changes? You can then share your findings here and might be able to create a PR for this change. See a previous PR #6726 for an example.

@voidzcy
Copy link
Contributor

voidzcy commented Aug 12, 2020

Duplicate of #1628, #2999, #6119.

No, we don't have a short-term plan for upgrading to okhttp3, it is a different implementation not a simple version bump. Your application shouldn't have a problem depending on both grpc-okhttp and okhttp3. Our usage of okhttp internals is very minimal and ProGuard will strip off unnecessary methods for you. You can see more information in #6119.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants