Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI over 1.7 rather than 1.8 #195

Open
chalin opened this issue Oct 21, 2020 · 3 comments
Open

Run CI over 1.7 rather than 1.8 #195

chalin opened this issue Oct 21, 2020 · 3 comments
Assignees

Comments

@chalin
Copy link
Contributor

chalin commented Oct 21, 2020

Currently CI is building and testing over Java 1.8 and 1.11, for example, see https://github.com/grpc/grpc-kotlin/pull/194/checks and the screenshot given below.

Since we're officially endorsing 1.7 as our min supported version of Java, the min Java version should probably be 1.7 in our CI jobs too. (This is partly a followup to #191 and #192.)

cc @davidjwiner

@jamesward
Copy link
Collaborator

I tried this in #193 but it didn't work / wasn't easy because gradle requires 1.8 to run. I'm sure there is a way to build an artifact with 1.8 (and have 1.7 compat) but then test the artifact with 1.7. However, before we invest the time we should see how much longer gRPC intends to support 1.7.

@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2020

However, before we invest the time we should see how much longer gRPC intends to support 1.7

Good idea!

@chalin
Copy link
Contributor Author

chalin commented Nov 17, 2020

Related: Drop support for Java 7, grpc/grpc-java#4671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants