Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidated Entities #40

Closed
zicklag opened this issue Dec 11, 2022 · 2 comments
Closed

Invalidated Entities #40

zicklag opened this issue Dec 11, 2022 · 2 comments

Comments

@zicklag
Copy link
Contributor

zicklag commented Dec 11, 2022

I just found that invalidating entities is still an issue, but luckily I also discovered the fix we need in the bevy_hierarchy crate. Just posting here for a heads-up in case anybody runs into it:

bevyengine/bevy#6790

For now, in my game I've just patched Bevy with the PR linked in the issue above to fix it.

Originally posted by @zicklag in #29 (comment)


I'm re-opening this issue because the fix I opened in Bevy wasn't accepted, because it could cause hierarchy inconsistencies. That's a valid point, but we need the behavior I added to make our entity updates work right.

I think what we have to do is we have to make a RollbackMapEntities trait that works essentially similar to the MapEntities trait, but with a slight behavior change, that we can implement for Parent and Children and that users can implement for their own component types that need entity mapping.

@johanhelsing
Copy link
Collaborator

I think we added a workaround for this in #74, if I understand this issue correctly. Should we close?

@gschup
Copy link
Owner

gschup commented Oct 26, 2023

I think yes! We can always reopen if this issue pops up again.

@gschup gschup closed this as completed Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants