Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

Rename "is_visible" method for more specialized traits #607

Open
GuillaumeGomez opened this issue Jun 30, 2021 · 1 comment
Open

Rename "is_visible" method for more specialized traits #607

GuillaumeGomez opened this issue Jun 30, 2021 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@GuillaumeGomez
Copy link
Member

Because currently we have the following error when using it:

error[E0034]: multiple applicable items in scope
   --> src/display_network.rs:113:34
    |
113 |                 if !filter_entry.is_visible() || filter_entry.text_length() < 1 {
    |                                  ^^^^^^^^^^ multiple `is_visible` found
    |
    = note: candidate #1 is defined in an impl of the trait `CellRendererExt` for the type `O`
    = note: candidate #2 is defined in an impl of the trait `EntryExt` for the type `O`
    = note: candidate #3 is defined in an impl of the trait `TreeViewColumnExt` for the type `O`
    = note: candidate #4 is defined in an impl of the trait `WidgetExt` for the type `O`
help: disambiguate the associated function for candidate #1
    |
113 |                 if !CellRendererExt::is_visible(&filter_entry) || filter_entry.text_length() < 1 {
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the associated function for candidate #2
    |
113 |                 if !EntryExt::is_visible(&filter_entry) || filter_entry.text_length() < 1 {
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the associated function for candidate #3
    |
113 |                 if !TreeViewColumnExt::is_visible(&filter_entry) || filter_entry.text_length() < 1 {
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: disambiguate the associated function for candidate #4
    |
113 |                 if !WidgetExt::is_visible(&filter_entry) || filter_entry.text_length() < 1 {
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@GuillaumeGomez GuillaumeGomez added the enhancement New feature or request label Jun 30, 2021
@sdroege
Copy link
Member

sdroege commented Jun 30, 2021

Probably also affect gtk4 @bilelmoussaoui

@sdroege sdroege mentioned this issue Oct 25, 2021
9 tasks
@GuillaumeGomez GuillaumeGomez added this to the 0.16 milestone Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants