-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Unionize parsing for cdx SBOM and VEX data #1247
Conversation
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
In general, it might make sense to move the parsing up to the Parse() function, and bubble up all errors there, then save the calculated ingestPredicates as a part of the struct, then GetPredicates() can just return them. It'll be nice to see the example json input and expected ingestPredicates outputs in the tests. |
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
For the "unknown time" where we want to put "zero time", use |
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @stevemenezes
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
LGTM! |
@stevemenezes just need to fix the CI errors and should be ready to merge |
Signed-off-by: stevemenezes <steve.menezes@yahooinc.com>
8387861
to
5a365ad
Compare
Description of the PR
Followup to #1181
PR Checklist
-s
flag togit commit
.make generate
has been runcollectsub
protobuf has been changed,make proto
has been run