Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KDF_PBKDF2 tests libraries including unsupported operations #73

Closed
koharin opened this issue Apr 4, 2024 · 2 comments
Closed

KDF_PBKDF2 tests libraries including unsupported operations #73

koharin opened this issue Apr 4, 2024 · 2 comments

Comments

@koharin
Copy link

koharin commented Apr 4, 2024

Hi.
I'm using cryptofuzz to test cryptographic libraries.

I recognized that when testing KDF_PBKDF2, it produces incorrect difference.
For example, KDF_PBKDF2 in libgmp, linux, mpdecimal, blst, libsodim, bearssl, trezor-firmware, openssl libraries don't support SHAKE digest.
However, cryptofuzz test KDF_PBKDF2 with SHAKE digest, so that it catches as result is not correct.

It would be better to filter out libraries with unsupported algorithms before testing algorithms.

Thank you for your works for Cryptofuzz.

@gilles-peskine-arm
Copy link
Contributor

This is the same problem as #69. You need to return std::nullopt in your Module implementation when given an unsupported or invalid input.

@koharin
Copy link
Author

koharin commented Aug 11, 2024

I'll add std::nullopt in module for unsupported input.
Thanks for your instruction.

@koharin koharin closed this as completed Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants