Add esbuild-register for typescript extensions

[hasparus]

Hi @phated 👋

I felt so smart with my workaround until you mentioned we could do this in a civilized way :P

[hasparus]

Test for .wisp is failing on my machine. Is this just on my side? Did I break it with my changes somehow?

[phated]

Thanks! Wisp is super old and I've always had problems with it. Don't worry about it here

[hasparus]

Thanks! Wisp is super old and I've always had problems with it. Don't worry about it here

All right 👌 LMK if there's something to change in my code then.

[phated]

It looks like this hooks too many extensions if you use it the "default" way: https://github.com/egoist/esbuild-register/blob/master/src/node.ts#L67-L74

I believe we need to implement this similar to babel/register. See their register function at https://github.com/egoist/esbuild-register/blob/master/src/node.ts#L96

[hasparus]

Makes sense — so we can pass just .ts or .tsx to extensions.

https://github.com/egoist/esbuild-register/blob/master/src/node.ts#L98

[phated]

Yep! We needed to add the "extended" config syntax so we didn't hook extra extensions with babel. We want to be really delicate with the hooking

[hasparus]

Ouch, we'll have to require esbuild-register/dist/node, right? It's not exposed to the outside.

Something like the following?

    {
      module: 'esbuild-register/dist/node',
      register: function(mod) {
        mod.register({
          extensions: '[.ts'],
          target: 'node' + process.version.slice(1),
        });
      },
    },

I'm not a huge fan of accessing /dist/node , but we also can't use esbuild directly, so maybe it
ould be better to create an issue asking if dist/node can be considered public API.

[phated]

I'd be fine with your snippet, but I also agree that it should probably be part of their public API. Not sure if that is something @egoist would want to do.

[hasparus]

Hey @phated, I just pushed the change with "extended" config syntax.

I'm not sure if it's all right, because now the require-xml test failed. Could I have broken it or is it a flaky test?

[phated]

Just flakey. We might just drop support for these extensions in a breaking release 🤔

[phated]

Thanks for doing this! 🙇

[hasparus]

Hey, I just remembered one thing — I didn't update the README to show this change in #API section, and neither did HRKings with swc in #74.

[phated]

Thanks! I'm actually hoping to finish #36 before we ship v3!