Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulePath is undefined when invoked from a namespaced npm module #91

Open
capaj opened this issue Mar 23, 2018 · 2 comments
Open

modulePath is undefined when invoked from a namespaced npm module #91

capaj opened this issue Mar 23, 2018 · 2 comments

Comments

@capaj
Copy link

capaj commented Mar 23, 2018

image

When I invoke CLI on my namespaced package @capaj/knex it doesn't get any modulePath passed to it.
@sttk
Copy link
Contributor

sttk commented Apr 4, 2018

Perhaps you need to set '@capaj/knex' to opts.moduleName of Liftoff constructor.

@phated
Copy link
Member

phated commented Apr 20, 2019

@sttk if opts.moduleName were specified as the namespaced module, wouldn't the file need to be named something like @capaj/knexfile.js? That would be super weird. Can we add a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phated @capaj @sttk