Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] PSR Standards #87

Closed
brianfreytag opened this issue Aug 1, 2017 · 4 comments
Closed

[FEATURE REQUEST] PSR Standards #87

brianfreytag opened this issue Aug 1, 2017 · 4 comments

Comments

@brianfreytag
Copy link
Contributor

I'd like to see this library get updated to utilize PSR standards.

One major thing I've noticed is that part of the library utilizes tab characters and others utilize 4 space indentation.

If I get a little free time, I will happily take a look at updating all of the variables, method definitions, spaces, etc... and put in a PR. I just want to know if there is any support for this from the maintainers. 1 or 2 thumbs up will be enough for me to put this on my "to-do" list.

@adityapatadia
Copy link
Contributor

Just ensure that you write unit tests accordingly. Target is also there to keep majority of code covered by unit tests.

@brianfreytag
Copy link
Contributor Author

Given that PSR (PHP Style Recommendations) are just coding-style changes, I don't see these changes breaking any of the unit tests, but I will certainly ensure that they don't. I will also apply PSR standards to the unit tests.

@adityapatadia
Copy link
Contributor

I think most of these changes were applied in #91

Closing this issue. If something is left, I will reopen later.

@rakshazi
Copy link
Contributor

I suggest you to use php-cs-fixer tool for autofix codestyle (not only psr 1/2), just use it in pre-commit hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants