Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress exif_read_data() errors #92

Closed
avataru opened this issue Sep 6, 2017 · 5 comments · Fixed by #93
Closed

Suppress exif_read_data() errors #92

avataru opened this issue Sep 6, 2017 · 5 comments · Fixed by #93

Comments

@avataru
Copy link

avataru commented Sep 6, 2017

exif_read_data() can sometimes generate errors and should be suppressed. The same suggestion is made in a comment to the SE post that served as inspiration for the imageCreateJpegfromExif() method.

@adityapatadia
Copy link
Contributor

It's already implemented in library. Are you using latest version?

@hultberg
Copy link
Contributor

hultberg commented Sep 7, 2017

@adityapatadia I think your misunderstanding @avataru, he is talking about php errors that one can not catch, but is just outputed directly. Thats why it should be supressed in this library, as you later checks if the data was retrieved. I opened #93

@hultberg
Copy link
Contributor

@adityapatadia Thanks for merging #93, could you please release a patch version to include the fixes?

@avataru
Copy link
Author

avataru commented Sep 11, 2017

Thank you @hultberg and @adityapatadia

@adityapatadia
Copy link
Contributor

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants