Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in definition after update to typescript-eslint v5 #36

Closed
alumni opened this issue Oct 11, 2021 · 4 comments
Closed

False positive in definition after update to typescript-eslint v5 #36

alumni opened this issue Oct 11, 2021 · 4 comments

Comments

@alumni
Copy link

alumni commented Oct 11, 2021

After updating typescript-eslint 4.33.0 to 5.0.0, all deprecated class members are show an error in the definition.

Example:

class Dog {
  sprint();

  /**
   * @deprecated Use {@link sprint} instead
   */
  walk();
}

The method walk would be highlighted as deprecated in the class definition.

@alumni
Copy link
Author

alumni commented Oct 18, 2021

Should be fixed by PR #38. typescript-eslint@5 renamed ClassProperty to PropertyDefinition

@gund
Copy link
Owner

gund commented Dec 14, 2021

This was released in v1.3.0. Could you please check if it's fixed for you?

@erik-kallen
Copy link

I'm having the same issue now. Using eslint-plugin-deprecation@1.3.2 with @typescript-eslint/eslint-plugin@5.30.5

@alumni
Copy link
Author

alumni commented Jul 6, 2022

For me it's all good.

@alumni alumni closed this as completed Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants