Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use round() instead of floor() for output image size #197

Merged
merged 1 commit into from
Aug 6, 2022
Merged

fix: use round() instead of floor() for output image size #197

merged 1 commit into from
Aug 6, 2022

Conversation

guoyingtao
Copy link
Owner

@guoyingtao guoyingtao commented Aug 6, 2022 •
edited
Loading

This PR fixes #195 and #198

@guoyingtao guoyingtao self-assigned this Aug 6, 2022
@guoyingtao guoyingtao added the bug Something isn't working label Aug 6, 2022
vanniktech
vanniktech approved these changes Aug 6, 2022
View reviewed changes
Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the fix for #198 ?

@guoyingtao
Copy link
Owner Author

Is this the fix for #198 ?

Yes

@guoyingtao guoyingtao merged commit 42bb6cc into master Aug 6, 2022
@guoyingtao guoyingtao deleted the fix-output-size branch January 28, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanniktech vanniktech vanniktech approved these changes

Assignees

@guoyingtao guoyingtao

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guoyingtao @vanniktech