-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using same ratio for both portrait and landscape images #87
Comments
@marko8994 Yes, it is possible. I can add a new config setting for it in the next release. |
@marko8994 I released Mantis 1.4.11 which includes this feature. I added public var fixRatiosShowType: FixRatiosShowType = .adaptive You can change this value to .horizontal or .vertical to use the same ratios for both portrait and landscape images. |
@guoyingtao, I see that you implemented this only in case we use RatioPresenter. Is it possible to add optional login for RatioSelector also since we are not using RatioPresenter? |
@marko8994 I added fixRatiosShowType setting to RatioSelecor in the master branch. I also moved fixRatiosShowType to Config.cropToolbarConfig var config = Mantis.Config()
config.cropToolbarConfig.ratioCandidatesShowType = .alwaysShowRatioList
config.cropToolbarConfig.fixRatiosShowType = .vetical Can you check if it is what you want? Then I can release a new version of Mantis. |
@guoyingtao, Yup, this is what we wanted. Everything works as expected. Thanks a lot. |
@marko8994 I just released Mantis 1.4.12 which includes this support. |
Is it possible to make custom ratios to be be fixed(not switching width and height) for both landscape and portrait images. We have some specific usage and we want custom ratios to be the same and not change.
Example:
config.addCustomRatio(byVerticalWidth: 3, andVerticalHeight: 4)
config.addCustomRatio(byVerticalWidth: 16, andVerticalHeight: 9)
The text was updated successfully, but these errors were encountered: