Issue 296 #343
Merged
Issue 296 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyonroche
requested changes
Jun 22, 2017
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "exceljs", | |||
| "version": "0.4.12", | |||
| "version": "0.4.13", | |||
There was a problem hiding this comment.
Bumping the package version is managed by the release scripts (npm version patch, etc). Please can you revert this line
| @@ -79,7 +79,7 @@ var utils = module.exports = { | |||
| }, | |||
| xmlEncode: function(text) { | |||
| // eslint-disable-next-line no-control-regex | |||
| return text.replace(/[<>&'"\x7F\x00-\x08\x0A-\x0C\x0E-\x1F]/g, function(c) { | |||
| return text.replace(/[<>&'"\x7F\x00-\x08\x0B-\x0C\x0E-\x1F]/g, function(c) { | |||
There was a problem hiding this comment.
Could you also add a unit test for this (in spec/unit/utils/utils.spec.js to ensure \x0a is retained
There was a problem hiding this comment.
Weird that the previous PR that was supposed to fix this same issue wasn't required to have a unit test.
There was a problem hiding this comment.
I had a lot more spare time then. Thanks for doing this - I'll publish tonight.
guyonroche
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let new lines through xmlEncode function. See github issue 296 (#296).