Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8 #2702

Closed
Nyholm opened this issue Jun 27, 2020 · 3 comments
Closed

Support PHP 8 #2702

Nyholm opened this issue Jun 27, 2020 · 3 comments
Labels
accept PRs
Milestone
7.2.0

Comments

@Nyholm
Copy link
Member

Nyholm commented Jun 27, 2020

We currently do not support PHP 8. We need to update CI config, update composer.json and make sure that we handle the new resource object in PHP 8.
@GrahamCampbell
Copy link
Member

I imagine phpstan might start to work against us here, lol. We'll have to be careful our types and phpdoc are accurate.

This was referenced Jun 28, 2020
Closed
Merged
@driesvints driesvints mentioned this issue Jul 28, 2020
Merged
17 tasks
@Nyholm Nyholm added this to the 7.2.0 milestone Oct 1, 2020
@Nyholm
Copy link
Member Author

Nyholm commented Oct 1, 2020

This is fixed in master.

@Nyholm Nyholm closed this as completed Oct 1, 2020
@loading84

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accept PRs
Projects
None yet
Milestone
7.2.0
Development

No branches or pull requests
4 participants
@Nyholm @GrahamCampbell @gmponos @loading84