Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] Adopt Naming Convention for Scorers #159

Open
nkpng2k opened this issue Feb 13, 2020 · 1 comment
Open

[CHORE] Adopt Naming Convention for Scorers #159

nkpng2k opened this issue Feb 13, 2020 · 1 comment
Assignees

Comments

@nkpng2k
Copy link
Contributor

nkpng2k commented Feb 13, 2020

As Per Comments Here:
#156 (comment)

Is a good idea to restructure this repository to adopt a naming convention for scorers. This will help to avoid confusion and also make the repository easier to manage.

personally, I'd advocate for nested dirs if possible, however, @osery comment suggested something similar to rest-scorer-local and rest-scorer-aws-lambda which would also work (and be less difficult to implement, since it more or less comes down to renaming dirs and projects. 😄 )

dai-deployment-templates
|-- aws
    |-- lambda
    |-- sagemaker
|-- gcp
    |-- cloud-run
|-- azure
|-- local 
@osery
Copy link
Contributor

osery commented Feb 18, 2020

Generally, I agree 👍.

But I am afraid that I will not be able to implement this due to my leaving the company end of Feb :-(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants