-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript build fails #1990
Comments
Seems related to #1971 |
@teabroker Can you please check this? |
Example of the failing build: urmaul/toot-feed-bot#276 |
@urmaul Can you please try 8.1.6? |
It works well with 8.1.6 |
I've checked this. It seems like my intention to remove types-only dependency from the dependencies to left only javascript's related was incorrect. So the library works well, when it is a single project and doesn't work when it's a dependency itself. I think it's a reason to check it automatically. Need to think how. @h3poteto you've rolled back too much. Now the typescript module is back to regular dependencies. I'm going to move typescript to devDependencies and left the types as it is in the 8.1.6 version. |
I've made a correction for PR #1971. |
This bug will affect only TS packages. But it seems reasonable to deprecate 8.1.5 version to prevent others from using it by occasion. Now it's still available for downloading without a notice at NPM registry. |
Well, I've checked this and it seems like there is only one type-dependency is in use. It's |
With megalodon version 8.1.5 in dependencies the typescript build fails with the error:
The text was updated successfully, but these errors were encountered: