Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move font-size delaration to html element #1411

Closed
wants to merge 1 commit into from
Closed

Move font-size delaration to html element #1411

wants to merge 1 commit into from

Conversation

robwierzbowski
Copy link

Since rems are based on the font-size of the html element we should probably move the font-size declaration there. This would set up reasonable expectations for the developer (edit font-size, change rems) without changing any current behavior (body { font-size: 1em } is implied).

The original commit to add body { font-size: 1em } is here. It seems it was added as a developer convenience, while line-height needed normalization.

@necolas
Copy link
Member

necolas commented Aug 2, 2013

May as well just change the selector from body to html. I usually set all these styles on the html element.

@robwierzbowski
Copy link
Author

It would be ideal to move line-height to html too, to keep related declarations together. Not sure / haven't tested if that causes issues in less capable browsers though.

@robwierzbowski
Copy link
Author

Looks like we cross-posted. I'm all for it, PR revised.

@necolas
Copy link
Member

necolas commented Aug 26, 2013

Thanks. Applied in ab6b2fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants